src/smblib smblib.c 1.205 1.206
Update of /cvsroot/sbbs/src/smblib
In directory cvs:/home/rswindell/sbbs/src/smblib

Modified Files:
smblib.c
Log Message:
Include more details in "illegal header length increase" error msg.


---
■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net

src/smblib smblib.c 1.206 1.207
Update of /cvsroot/sbbs/src/smblib
In directory cvs:/tmp/cvs-serv6132

Modified Files:
smblib.c
Log Message:
On Windows, smb_addmsg() was slow because smb_updatethread() was slow:

So on Windows, calling unlock() on a file region that you don't have locked, incurs a delay. Likewise, calling lock() on a file region that already have locked incurs a delay. These delays were seriously throttling message imports on Windows (e.g. importing echomail or QWK packets). What should take a few seconds, was taking minutes with noticeable delays. This code has been performing redundant locks/unlocks for over 15 years, so I can only conclude that the performance penalty is a new behavior introduced in recent version(s) of Windows.

---
■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net

src/smblib smblib.c 1.207 1.208
Update of /cvsroot/sbbs/src/smblib
In directory cvs:/tmp/cvs-serv11249

Modified Files:
smblib.c
Log Message:
Some very old, yet inconsistent, behavior of smb_hfield_add() could pretty easily result in a message body being added to a message base with no accompanying message header: if the header data was 0-length, the hfield_dat was not actually allocated and the applicable smbmsg_t convenience pointer was not set accordingly. This had the side effect that if a message were to be imported with a blank recipient ("To" field), the header was not created at
all (to support mutliple header, single body msgs, i.e. bulkmail).
The other functions that set the convenience pointers do not treat 0-length header field data special, so this was inconsistent behavior.
Most message types (e.g. networks) don't want 0-length "to" fields, but that shoudl be enforced somewhere else, not here.

---
■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net

src/smblib smblib.c 1.208 1.209
Update of /cvsroot/sbbs/src/smblib
In directory cvs:/tmp/cvs-serv3248

Modified Files:
smblib.c
Log Message:
smb_hfield_add_netaddr():
Don't strip the "user@" portion of a *NETADDR header field if the specified net-type is NET_NONE.

---
■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/05104f134188b139a6f3e5ba
Modified Files:
src/smblib/smblib.c
Log Message:
When a message has been forwarded, invalidate the "to" ext/net ptrs

The convenience pointers to_ext and to_net need to be invalidated (nullified) if we are going to allow forwarding from local email boxes to network mail and keep all the original message header fields in tact.

The "Forwarded" field must now be added *before* any new recipient information (local user extension or network address of the forwarding destination).

This is part of the solution to request #83, #108, and #141.
---
■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/2ee37e4ee9e91ddb2d790f72
Modified Files:
src/smblib/smblib.c
Log Message:
Fix the relocation of enlarged message headers in smb_putmsghdr()

The first commit of this feature would leave the base corrupted for a couple
of reasons (.sha file wasn't opened, using modified header when re-writing the old header to set the DELETED attribute). Both fixed.
---
■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/b5c5630c1ccd675a559dd98d
Modified Files:
src/smblib/smblib.c
Log Message:
More detail in error strings in smb_getmsghdr()
---
■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/4985797d2b07ca169326ab6f
Modified Files:
src/smblib/smblib.c
Log Message:
Streamlined code: we need only one check for hyper-alloc'd msg base here

No functional change.
---
■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/47fe4a60247147dc217ad02b
Modified Files:
src/smblib/smblib.c
Log Message:
Fix stale comments (msg.offset became msg.idx_offset a couple years back).
---
■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net